Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANIFEST] Revert "Revert "Revert "feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging""" #2662

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jun 5, 2024

Reverts #2636

@ben851 ben851 marked this pull request as ready for review June 5, 2024 16:03
@ben851 ben851 requested a review from jimleroyer as a code owner June 5, 2024 16:03
Copy link

github-actions bot commented Jun 5, 2024

github-arc-ss-staging	github-arc-controller	7       	2024-06-03 14:05:38.96370194 +0000 UTC	deployed	gha-runner-scale-set-0.8.2	0.8.2      

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=karpenter-crd, chart=/tmp/helmfile2143453033/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile2143453033/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile2143453033/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress

@sastels sastels requested a review from ben851 June 5, 2024 16:04
@sastels sastels changed the title Revert "Revert "Revert "feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging""" [MANIFEST] Revert "Revert "Revert "feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging""" Jun 5, 2024
Copy link
Collaborator

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels merged commit 9a4143f into main Jun 5, 2024
4 checks passed
@sastels sastels deleted the revert-2636-revert-2634-revert-2627-add-AWS_PINPOINT_DEFAULT_POOL_ID-variable branch June 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants