Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change process type values to be consistent #2208

Closed
wants to merge 4 commits into from

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented Jul 8, 2024

Summary | Résumé

Quick PR to fix the sms/email process type values for the default categories. Rather than high, normal, low, we'll use priority, normal, bulk for consistency sake.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

  1. Run the migration
  2. Check your local DB
  3. Note that the values for sms/email_process_type in the default categories are priority, normal, bulk.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@jzbahrai
Copy link
Collaborator

jzbahrai commented Jul 8, 2024

you can't change a migration once it has been run, you have to add a new migration.

@whabanks
Copy link
Contributor Author

whabanks commented Jul 8, 2024

Closing because we need a new migration file not an edit.

@whabanks whabanks closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants