-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial TemplateCategory client #1884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://y2o5mugz7qqc3vxonetokrd3xq0yxrdp.lambda-url.ca-central-1.on.aws/ |
- Implemented add and update a category - Tweaks to the api client - Added tests for the API client - Renamed desc_en/desc_fr to description_en/fr for consistency
5 tasks
andrewleith
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One issue when trying to add a new category, and one cache issue when trying to update a category - both detailed below.
- Fixed desc_en/desc_fr -> description_en/description_fr typos - Delete the template_categories key when updating a category - Updated tests to check we are properly deleting Redis cache keys when updating a template
- Fix tests
- Added mock to get all template categories - Added template_category_json() - Updated template_json() with a template_category param - Sorted config keys under config.py
andrewleith
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR implements the
template_category_api_client
, implementing the following functionality on the platform admin pages.Related issues
Test instructions | Instructions pour tester la modification
Template Categories
platform admin page - Note that the three generic categories are presentNew Category
button - Fill out the form and create the category - Note you're taken back to the list of template categories pagehidden
,sms priority
,email priority
- Save the category