Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/opted out phone numbers in pinpoint #2207

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jul 4, 2024

Summary | Résumé

The Pinpoint boto call throws an exception if we try to send to a phone number that has opted out. (SNS will accept the boto call and later log that the number has opted out).

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

  1. Make sure Pinpoint is configured.
  2. Send yourself a text.
  3. Reply "STOP" to opt out.
  4. After ten or so seconds send yourself another text.
  5. Within a few seconds the status of the notification should be "Phone number is opted out".
  6. In staging or locally reply "START" to opt back in.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels force-pushed the fix/pinpoint-to-opted-out-numbers branch from 1e24b2a to f1daf45 Compare July 4, 2024 20:42
@sastels sastels force-pushed the fix/pinpoint-to-opted-out-numbers branch from 182e21a to 288b134 Compare July 8, 2024 16:18
@sastels sastels marked this pull request as ready for review July 8, 2024 18:22
@sastels sastels requested review from jimleroyer and ben851 July 8, 2024 18:43
Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@sastels sastels merged commit 45442d0 into main Jul 8, 2024
4 checks passed
@sastels sastels deleted the fix/pinpoint-to-opted-out-numbers branch July 8, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants