-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the Pinpoint default pool #370
Comments
Add the default pool to k8s but set |
Will release tomorrow. After that, will turn on in staging. |
PR to set phone number keywords correctly PR to turn on the default pool in staging: |
Default pool enabled in staging, looks pretty good! |
PR for script to set phone number keywords correctly is ready for 👀 : |
This was merged and moving in QA. Jimmy will review the keywords messages in staging env. |
Long codes in production have been moved to the default pool and had their keywords set appropriately. Trying to set the
|
Having a bug bash on staging Tuesday. |
Jimmy reviewed the keywords and these look good! |
Bug bash went well, no blockers found. Tested sending with the default pool in production with
Verified that the SMS was sent from one of the long codes in the default pool. |
Targeting release to production Wednesday June 19, 10:30.
|
Had a problem sending to non-US international numbers 😞 testing in staging..... |
Also found that in the repo and staging SNS is not allowed to send internationally. It has been manually enabled in the prod database. We should fix this with a migration. At the same time we can probably turn on international sending for Pinpoint. |
Discovered what the
|
Enable international sending for SNS and Pinpoint in our provider database via a migration: Tweak the pool creation script to enable shared routes for new Pinpoint pools: After these two are merged (and the existing Pinpoint pools in staging and production have shared_routes enabled) we can turn on international Pinpoint sending again: |
ok, everything's been reviewed and approved! Will merge into staging and test today. |
merged into staging and tested (Pinpoint configured there for default pool) Next steps:
|
Ready to enable the default pools. |
Will we need to have specific sender ids in pinpoint? 🤔 |
There's a |
that didn't work as expected, I put in a support ticket. I might change back to using Pinpoint for everything except international (and designated numbers) until we get this sorted. |
Use SNS for international: Turn the default pool back on in staging |
PRs merged, updated and went through staging QA steps again 🎉 |
note from AWS: to use the default sender id in Pinpoint we need to send without an origination-identity. So, essentially, to send internationally we should not supply a pool. |
PR to turn on default pool in prod |
Turned on in prod and prod QA tests pass. Continuing to monitor... |
Pinpoint SendTextMessage throws a
This notification has status "... is opted out", but I think that's because after the Pinpoint celery error it retried with SNS. SNS tries to send it (and charges us) and returns that status. So with Pinpoint we should catch the celery error and update the status without having SNS send it. |
WIP PR to fix the opted out error: PR to fix a couple things on the Pinpoint dashboard: |
|
We should add a card wrt SNS alarms, ie at least make critical alarm non-paging |
releasing the opted out numbers fix to prod today |
released and opted out number tested. Ready for QA! |
Jimmy to QA. |
QA notes.
|
Jimmy experienced some issues with Proovl (as per the steps above). Steve says Proovl might have been experiencing issues yesterday, so Jimmy might try again today. |
I updated the test cases with the results along with some notes. This issue can be considered QA'ed successfully. |
Description
As a Notify team member, I need to be able to decide which SMS gets sent not using the short code.
WHY are we building?
Currently we can specify templates that are sent with the shortcode. However the other templates will also often get sent with the shortcode. We would like to have the other templates sent with the long codes.
WHAT are we building?
Create / turn on the Pinpoint default pool.
VALUE created by our solution
Fewer messages sent via short code. This will save money and allow us to reserve the short code for high priority messages.
Acceptance Criteria
Given some context, when (X) action occurs, then (Y) outcome is achieved.
QA Steps
Staging
Production
The text was updated successfully, but these errors were encountered: