Task: Filter Heartbeats #2108
Merged
Task: Filter Heartbeats #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Feb 9, 2024
whabanks
approved these changes
Feb 16, 2024
whabanks
added a commit
that referenced
this pull request
Feb 21, 2024
jzbahrai
added a commit
that referenced
this pull request
Feb 26, 2024
* Add filter for heartbeat template * fix formatting * Edit and add a test * test for rest endpoint * Add filter heartbeats for live service data
jzbahrai
added a commit
that referenced
this pull request
Feb 27, 2024
* Add filter for heartbeat template * fix formatting * Edit and add a test * test for rest endpoint * Add filter heartbeats for live service data
jzbahrai
added a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
We need a way to filter heartbeats when calculating the activity for daily usage. We added a default param with no value, to add a way to filter heartbeat templates
Test instructions | Instructions pour tester la modification
https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1495