Filtering heartbeats #1755
Merged
Filtering heartbeats #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://snxywcwvtlbxymxr47xvhqui3e0ijjrr.lambda-url.ca-central-1.on.aws/ |
whabanks
approved these changes
Feb 16, 2024
whabanks
added a commit
that referenced
this pull request
Feb 21, 2024
jzbahrai
added a commit
that referenced
this pull request
Feb 26, 2024
* Filtering heartbeats * add missing filter for main page * Added tests --------- Co-authored-by: wbanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
PR to add a fitler_heartbeats param to send to the API. This PR requires:
cds-snc/notification-api#2108
to be merged.
Test instructions | Instructions pour tester la modification
NOTE: This PR has no tests! I will add the tests when I come back, just putting the PR as a ready to review if it absolutely needs to go out.
Once the api PR is merged to staging, the best way to test this PR is to use the REVIEW APP.
When you go to notification.canada.ca MAIN page and scroll to the bottom, you should see a different number in the review app and a different number on staging.notification.canada.a (if this PR is not merged)
on the main page
on the /activity page
