Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for metrics #75

Merged
merged 5 commits into from
Jan 4, 2024
Merged

feat: Add support for metrics #75

merged 5 commits into from
Jan 4, 2024

Conversation

kozub
Copy link
Contributor

@kozub kozub commented Jan 4, 2024 •
edited
Loading

Support for raporting the following metrics in the AWS/AppFlow namespace:

  • FlowExecutionsStarted
  • FlowExecutionsFailed
  • FlowExecutionsSucceeded
  • FlowExecutionTime
  • FlowExecutionRecordsProcessed

details: https://docs.aws.amazon.com/appflow/latest/userguide/monitoring-cloudwatch.html

@kozub kozub requested a review from rpawlaszek January 4, 2024 10:34
rpawlaszek
rpawlaszek approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@rpawlaszek rpawlaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rpawlaszek
rpawlaszek requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@rpawlaszek rpawlaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions:

  • add JSDoc descriptions of the methods
  • add a paragraphs in the README to surface the information.

rpawlaszek
rpawlaszek approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@rpawlaszek rpawlaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 558f9df into main Jan 4, 2024
12 checks passed
@mergify mergify bot deleted the kozub/metrics branch January 4, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpawlaszek rpawlaszek rpawlaszek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozub @rpawlaszek