Use the new insets API in EmojiSearch #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Nov 19, 2024
| @@ -275,6 +276,7 @@ internal class UIViewLazyList : | |||
| rowHeight = UITableViewAutomaticDimension | |||
| separatorStyle = UITableViewCellSeparatorStyleNone | |||
| backgroundColor = UIColor.clearColor | |||
| contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever | |||
There was a problem hiding this comment.
Without this, UIScrollView adds the appropriate amount of space after the last element automatically, and we get double the space that we want.
There was a problem hiding this comment.
(Though I didn’t see this behavior in Column(overflow = Scroll), which is surprising)
AndroidWe draw all the way to the bottom edge of the screen: And put space under the last element so it isn’t obscured by the bottom line thing: iOSDraw all the way to the bottom edge: Space under the last element: |
JakeWharton
approved these changes
Nov 20, 2024
swankjesse
force-pushed
the
jwilson.1119.insets_runtime
branch
2 times, most recently
from
1a60f52 to
eced783
Compare
swankjesse
force-pushed
the
jwilson.1119.insets_emojisearch
branch
from
cc5645c to
41fbc99
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.