Fix inconsistency in margin application between ComposeUiBox and ViewBox
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewBox` Relates to #2367 In compose ui, modifier order matters and applying padding before a background prevents the background from filling the box.
JakeWharton
reviewed
Nov 21, 2024
There was a problem hiding this comment.
This test is still pretty fucked, but the other one now matches 👍
There was a problem hiding this comment.
Yeah I'm gonna try and fix this one next. Side note, I think #2464 broke emoji search for views.
JakeWharton
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2367
In compose ui, modifier order matters and applying padding before a background prevents the background from filling the box.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.