Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer serializing event args to JSON #2218

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

JakeWharton
Copy link
Collaborator

Until we're on the Zipline thread instead of the UI thread.

Half of #2145.


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

Until we're on the Zipline thread instead of the UI thread.
@JakeWharton JakeWharton force-pushed the jw.defer-event-serialization.2024-07-30 branch from c69ab16 to 0779b75 Compare July 31, 2024 14:30
@JakeWharton JakeWharton enabled auto-merge (squash) July 31, 2024 17:34
@JakeWharton JakeWharton merged commit 4010e12 into trunk Jul 31, 2024
11 checks passed
@JakeWharton JakeWharton deleted the jw.defer-event-serialization.2024-07-30 branch July 31, 2024 18:03
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COOOL

dnagler added a commit that referenced this pull request Aug 7, 2024
swankjesse pushed a commit that referenced this pull request Aug 7, 2024
swankjesse pushed a commit that referenced this pull request Aug 26, 2024
swankjesse pushed a commit that referenced this pull request Aug 26, 2024
swankjesse pushed a commit that referenced this pull request Aug 26, 2024
* Reapply "Defer serializing event args to JSON (#2218)" (#2239)

This reverts commit 5f8ca01.

* Track API change in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants