Reapply "Defer serializing event args to JSON (#2218)" (#2239) #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Aug 26, 2024
| @@ -64,7 +65,7 @@ class ViewRecyclingTester( | |||
| container = widgetContainer, | |||
| factory = widgetProtocolFactory, | |||
| eventSink = { event -> | |||
| guestAdapter.sendEvent(event) | |||
| guestAdapter.sendEvent(event.toProtocol(Json.Default)) | |||
There was a problem hiding this comment.
This wasn’t in the original PR, because this test is new!
JakeWharton
approved these changes
Aug 26, 2024
swankjesse
force-pushed
the
jwilson.0826.restore_json
branch
from
06d2e9c to
cd4bad5
Compare
|
I’m set up to test it end-to-end now and I’ll confirm it works before I merge... |
Thanks! As a reminder, the bug would only manifest after scrolling down a few pages (to force some recycling to occur) |
|
Yep, confirmed the bug is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f8ca01.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.