Extract an interface for LoadingStrategy #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Jul 31, 2024
| */ | ||
| package app.cash.redwood.lazylayout.compose | ||
|
|
||
| public interface LoadingStrategy { |
There was a problem hiding this comment.
I wanted this because I was writing a test for some internal Cash code and I didn’t like my test accidentally exercising all of this policy.
JakeWharton
reviewed
Jul 31, 2024
Comment on lines
33
to
+34
| return rememberSaveable(saver = saver) { | ||
| LazyListState() | ||
| LazyListState(strategy) |
There was a problem hiding this comment.
Seems like strategy needs to be added as a key to rememberSaveable. Otherwise changes in strategies would not reinitialize the state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.