Fix the flex property on iOS not being respected. #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Dec 5, 2023
| @@ -31,10 +31,11 @@ internal class YogaUIView( | |||
| var height = Constraint.Wrap | |||
|
|
|||
| init { | |||
| // TODO: Support Scroll Indicators | |||
| // TODO: Support scroll indicators. | |||
| scrollEnabled = false | |||
There was a problem hiding this comment.
This is the one-line fix.
JakeWharton
approved these changes
Dec 5, 2023
dnagler
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1699. This PR fixes
Modifier.flexon iOS.The root cause was
scrollEnableddefaulting totrueand theYogaLayout's first layout pass would occur before it was set tofalseby Redwood. That first pass would set each child's frame such that it would affect the later measurement passes.flexrelies onflexBasis, which has no effect when the main axis size is undefined (like when measuring a row with scroll enabled).This PR also includes some minor formatting changes.