Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Child Column views can overflow the bounds of their parents #1389

Closed
dnagler opened this issue Aug 4, 2023 · 2 comments
Closed

[iOS] Child Column views can overflow the bounds of their parents #1389

dnagler opened this issue Aug 4, 2023 · 2 comments
Assignees

Comments

@dnagler
Copy link
Collaborator

dnagler commented Aug 4, 2023

While implementing the Activity receipt view on iOS, I noticed some unexpected behavior with the Column view. The UI is defined as follows:

Column(
  width = Constraint.Fill,
  height = Constraint.Fill,
  horizontalAlignment = CrossAxisAlignment.Center,
) {
  Column(
    modifier = Modifier,
    width = Constraint.Fill,
    horizontalAlignment = CrossAxisAlignment.Center,
  ) {
    // Header view
  }
  Column(
    modifier = Modifier.grow(1.0),
    horizontalAlignment = CrossAxisAlignment.Center,
    width = Constraint.Fill,
    height = Constraint.Fill,
    verticalAlignment = MainAxisAlignment.Center,
    margin = Margin(bottom = 24.dp),
  ) {
    // Body view
  }
}

In Xcode's view debugger, I'm seeing the following:

image

Note how the body view extends far below the bounds of its parent. This seems like a bug to me, or unexpected behavior at the very least.

@dnagler
Copy link
Collaborator Author

dnagler commented Aug 23, 2023

Added an example in PR #1420

@dnagler
Copy link
Collaborator Author

dnagler commented Dec 11, 2023

@colinrtwhite I think we can close this, now that #1724 has landed (thanks again for taking a look!)

colinrtwhite added a commit that referenced this issue Dec 12, 2023
colinrtwhite added a commit that referenced this issue Feb 29, 2024
colinrtwhite added a commit that referenced this issue Mar 1, 2024
* Add regression test for #1389.

* Revert.

* Fix test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants