Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bits of cleanup In UIViewLazyList #1659

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Two bits of cleanup In UIViewLazyList #1659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ylayout-uiview/src/commonMain/kotlin/app/cash/redwood/lazylayout/uiview/UIViewLazyList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ internal class LazyListContainerCell(
removeAllSubviews()
if (value != null) {
contentView.addSubview(value.value)
contentView.translatesAutoresizingMaskIntoConstraints = false
}
setNeedsLayout()
}
Expand Down Expand Up @@ -273,6 +272,7 @@ internal class LazyListContainerCell(

override fun prepareForReuse() {
super.prepareForReuse()
removeAllSubviews()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds right for what we have. wishful thinking would be that these views stay put and redwood could just modify the values of them to actually reuse the cell

binding?.unbind()
binding = null
}
Expand Down