Two bits of cleanup In UIViewLazyList #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing call to set contentView.translatesAutoresizingMaskIntoConstraints to false, because this is not supported by iOS, and yields the following warning: "Changing the translatesAutoresizingMaskIntoConstraints property of the contentView of a UITableViewCell is not supported and will result in undefined behavior, as this property is managed by the owning UITableViewCell" - Adding call to removeAllSubviews within prepareForReuse
JakeWharton
approved these changes
Oct 31, 2023
| @@ -273,6 +272,7 @@ internal class LazyListContainerCell( | |||
|
|
|||
| override fun prepareForReuse() { | |||
| super.prepareForReuse() | |||
| removeAllSubviews() | |||
There was a problem hiding this comment.
this sounds right for what we have. wishful thinking would be that these views stay put and redwood could just modify the values of them to actually reuse the cell
underscoretang
approved these changes
Oct 31, 2023
swankjesse
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Changing the translatesAutoresizingMaskIntoConstraints property of the contentView of a UITableViewCell is not supported and will result in undefined behavior, as this property is managed by the owning UITableViewCell"