Promote more lifecycle to ZiplineCodeSession #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.1030.promote_to_codesession
branch
from
7963352 to
2d69dce
Compare
|
Part of #1458 |
|
JakeWharton
approved these changes
Oct 31, 2023
swankjesse
force-pushed
the
jwilson.1030.uncaught_exceptions_async
branch
from
eb89498 to
603b8ce
Compare
Base automatically changed from
jwilson.1030.uncaught_exceptions_async
to
trunk
November 1, 2023 03:42
Previously TreehouseApp was tracking exceptions on behalf of a class that could do it better. This introduces listeners at the CodeSession level in addition to the existing listeners at the CodeHost level.
swankjesse
force-pushed
the
jwilson.1030.promote_to_codesession
branch
from
621c4fe to
c7ef6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously TreehouseApp was tracking exceptions on behalf of a class that could do it better.
This introduces listeners at the CodeSession level in addition to the existing listeners at the CodeHost level.