CodeListener.onUncaughtException #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
19b61bc to
df396a6
Compare
swankjesse
changed the title
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
6317805 to
9762a1d
Compare
swankjesse
changed the title
crash.mp4 |
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
9762a1d to
7a96d43
Compare
|
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
6cfa5d6 to
7a96d43
Compare
|
Part of #1458 |
veyndan
reviewed
Oct 31, 2023
|
|
||
| private inner class ZiplineCodeHost<A : AppService> : CodeHost<A> { |
There was a problem hiding this comment.
Was their a requirement to make this an inner class?
(My over dislike of inner class may have motivated this comment 😅)
There was a problem hiding this comment.
It reduces the amount of boilerplate to share state with the enclosing class.
redwood-treehouse-host/src/commonMain/kotlin/app/cash/redwood/treehouse/TreehouseDispatchers.kt
Show resolved
Hide resolved
veyndan
approved these changes
Oct 31, 2023
JakeWharton
approved these changes
Oct 31, 2023
...d-views/src/main/kotlin/com/example/redwood/emojisearch/android/views/EmojiSearchActivity.kt
Outdated
Show resolved
Hide resolved
redwood-treehouse-host/src/commonMain/kotlin/app/cash/redwood/treehouse/TreehouseApp.kt
Show resolved
Hide resolved
swankjesse
force-pushed
the
jwilson.1027.back_listener_cleared
branch
from
e3659c2 to
4d8dd7e
Compare
This new API is called on host views when the guest code fails with an uncaught exception. This wires in a CoroutineExceptionHandler in the host code that cancels the current Zipline instance and updates all UIs its currently serving, if any. There is not yet any support for exceptions that occur in async code, or any mechanism to restart the Zipline instance after a crash.
…/redwood/emojisearch/android/views/EmojiSearchActivity.kt Co-authored-by: Jake Wharton <[email protected]>
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
54e0a63 to
3c6ff73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.