Add UIViewBox Implementation #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2023
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
underscoretang
force-pushed
the
box/test_app
branch
from
7e10282 to
6b48230
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
4d61460 to
fad23ca
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
fad23ca to
f4fcc65
Compare
underscoretang
force-pushed
the
box/test_app
branch
from
6b48230 to
32eb24b
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
f4fcc65 to
ca1657a
Compare
underscoretang
requested review from
JakeWharton,
swankjesse,
dnagler,
colinrtwhite and
veyndan
dnagler
reviewed
Sep 30, 2023
| }, | ||
| remove = { index, count -> | ||
| val views = Array(count) { | ||
| typedSubviews[index].also(UIView::removeFromSuperview) |
There was a problem hiding this comment.
nit: just to be safe, it can't hurt to bail early if index >= typedSubviews.size, and maybe throw an error rather than crashing
There was a problem hiding this comment.
Generally our strategy has been to explode loudly on unexpected input. It gives bugs fewer places to hide!
underscoretang
force-pushed
the
box/test_app
branch
from
32eb24b to
f962916
Compare
underscoretang
force-pushed
the
box/ui_view
branch
2 times, most recently
from
3b7a130 to
fd07927
Compare
underscoretang
force-pushed
the
box/test_app
branch
from
f962916 to
4c6de08
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
fd07927 to
fda8102
Compare
underscoretang
force-pushed
the
box/test_app
branch
from
4c6de08 to
1baf9ef
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
fda8102 to
02dd0f2
Compare
underscoretang
force-pushed
the
box/ui_view
branch
from
02dd0f2 to
0470b50
Compare
swankjesse
approved these changes
Oct 4, 2023
| }, | ||
| remove = { index, count -> | ||
| val views = Array(count) { | ||
| typedSubviews[index].also(UIView::removeFromSuperview) |
There was a problem hiding this comment.
Generally our strategy has been to explode loudly on unexpected input. It gives bugs fewer places to hide!
colinrtwhite
approved these changes
Oct 4, 2023
underscoretang
force-pushed
the
box/ui_view
branch
from
0470b50 to
2119bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some of the layouts that this creates
I had to do some custom coloring of things inside of the widgets that I won't make part of this commit. I think I'll follow up with adding a backgroundColor property to the Button widget inside of test-app, but hoping to lean on #1541 for full support
The blue background is the actual
Boxwidget.The green background is the
Rowthat theBoxis contained inThe elements inside the box have outlines and their own colors
And this is how it looks without colors as a point of reference: