Add Box widget schema for redwood layout #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM so far |
underscoretang
force-pushed
the
box/widget-schema
branch
2 times, most recently
from
bc00413 to
22c85e3
Compare
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 29, 2023
Merged
underscoretang
changed the title
underscoretang
commented
Sep 29, 2023
|
|
||
| @Property(5) | ||
| @Default("Dp(0.0)") | ||
| val minHeight: Dp, |
There was a problem hiding this comment.
Do folks think that these would be useful?
There was a problem hiding this comment.
I think it's fine to be here, as long as it is a no-op when not assigned
There was a problem hiding this comment.
I would not add any new properties that are not fundamentally intrinsic to the display of Box. Things like minHeight/minWidth are equally as applicable to Row or Column, and we should discuss their inclusion separately so as to not distract from getting Box landed.
There was a problem hiding this comment.
cc: @swankjesse going to remove these
underscoretang
requested review from
JakeWharton,
veyndan,
swankjesse,
colinrtwhite and
jingwei99
underscoretang
force-pushed
the
box/widget-schema
branch
2 times, most recently
from
aec7e0f to
93e9866
Compare
jingwei99
approved these changes
Oct 2, 2023
underscoretang
force-pushed
the
box/widget-schema
branch
from
93e9866 to
9026151
Compare
underscoretang
force-pushed
the
box/widget-schema
branch
from
9026151 to
1a6dbeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.