Set Android View ID on TreehouseLayout by default
#1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one doesn't explicitly set an Android View ID, `onSaveInstanceState` is never invoked, and thus `rememberSaveable` will never work as intended.
veyndan
force-pushed
the
veyndan/2023-09-28/TreehouseLayoutId
branch
from
77b860d to
7ec4832
Compare
jingwei99
approved these changes
Sep 28, 2023
JakeWharton
approved these changes
Sep 28, 2023
redwood-treehouse-host/src/androidMain/kotlin/app/cash/redwood/treehouse/TreehouseLayout.kt
Outdated
Show resolved
Hide resolved
redwood-treehouse-host/src/androidMain/kotlin/app/cash/redwood/treehouse/TreehouseLayout.kt
Outdated
Show resolved
Hide resolved
JakeWharton
force-pushed
the
veyndan/2023-09-28/TreehouseLayoutId
branch
from
7c21626 to
570e085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one doesn't explicitly set an Android View ID,
onSaveInstanceStateis never invoked, and thusrememberSaveablewill never work as intended.