Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save screen location across recreation #1536

Merged

Conversation

ahmed3elshaer
Copy link
Contributor

@ahmed3elshaer ahmed3elshaer commented Sep 28, 2023

  • Changed remember to rememberSavable to survive configuration changes.

It depends on merging #1533 to be tested.

@ahmed3elshaer ahmed3elshaer force-pushed the save-screen-location-across-recreation branch 2 times, most recently from 95553c9 to 1267def Compare September 28, 2023 23:11
@JakeWharton JakeWharton force-pushed the save-screen-location-across-recreation branch from 1267def to 1a396f9 Compare September 30, 2023 01:02
@swankjesse swankjesse requested a review from jingwei99 October 10, 2023 14:06
@JakeWharton
Copy link
Collaborator

We can merge this because it no longer crashes, at least, but it does not actually fix the problem as discussed on the issue.

@JakeWharton JakeWharton merged commit edce741 into cashapp:trunk Oct 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants