Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layoutlib to v14.0.9 (Koala Feature Drop +) #1487

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.android.tools.layoutlib:layoutlib-runtime (source) 14.0.8 -> 14.0.9 age adoption passing confidence
com.android.tools.layoutlib:layoutlib-resources (source) 14.0.8 -> 14.0.9 age adoption passing confidence
com.android.tools.layoutlib:layoutlib (source) 14.0.8 -> 14.0.9 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@geoff-powell
Copy link
Collaborator

geoff-powell commented Jun 21, 2024

Looks like the only failing test is the widgets project. Seems like the navigation icons changed. 🤔

Before

full_screen

After

1f5c5b2c9ba49181598c07c7703e9c13f9750be2

Diff

Screenshot 2024-06-21 at 10 53 14 AM

@renovate renovate bot force-pushed the renovate/layoutlib branch 4 times, most recently from 962fc1c to 5847477 Compare June 27, 2024 18:14
@renovate renovate bot force-pushed the renovate/layoutlib branch 6 times, most recently from cd2ed3e to 694aa7c Compare July 9, 2024 13:00
@renovate renovate bot force-pushed the renovate/layoutlib branch 2 times, most recently from 0693c4e to 625f370 Compare July 12, 2024 03:20
@renovate renovate bot force-pushed the renovate/layoutlib branch from 625f370 to 5607758 Compare July 12, 2024 03:38
@geoff-powell
Copy link
Collaborator

geoff-powell commented Jul 12, 2024

Update here, I think this bump in layoutlib is tied to AS Koala Feature Drop release.

Looking in Jellyfish AS instance the previous navigation icons are shown.
Screenshot 2024-07-12 at 11 27 49 AM

When opening Koala 2024.2.1 (feature drop) the navigation icons have changed. So I am assuming that this version 14.0.9 is using layoutlib version used in that version or later. [still need to test AS Ladybug]
Screenshot 2024-07-12 at 11 24 34 AM

Copy link
Contributor Author

renovate bot commented Jul 12, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@geoff-powell geoff-powell changed the title Update layoutlib to v14.0.9 Update layoutlib to v14.0.9 (Koala Feature Drop +) Jul 12, 2024
Comment on lines 305 to 307
// When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test.
// When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1
// and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test.
// When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1
// and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index.

good context for a PR comment today. But it's not a controversial code change (worst case, it's defensive) and the code comment will likely grow stale if Compose implementation details change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I will move this to a PR comment for context.


      // When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test.
      // When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1
      // and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index.
      

@geoff-powell
Copy link
Collaborator

@jrodbx curious, now that we are using the provided google artifacts for layoutlib, do you know if we can pull which version of AS corresponds with?

@jrodbx
Copy link
Collaborator

jrodbx commented Jul 12, 2024

@jrodbx curious, now that we are using the provided google artifacts for layoutlib, do you know if we can pull which version of AS corresponds with?

AFAIK, there's no simple way to extract that programmatically. However, I have asked for that very mapping and an issue has been filed here.

@geoff-powell
Copy link
Collaborator

@jrodbx curious, now that we are using the provided google artifacts for layoutlib, do you know if we can pull which version of AS corresponds with?

AFAIK, there's no simple way to extract that programmatically. However, I have asked for that very mapping and an issue has been filed here.

cool, +1'd the filed issue

@geoff-powell geoff-powell merged commit 2153344 into master Jul 12, 2024
14 checks passed
@geoff-powell geoff-powell deleted the renovate/layoutlib branch July 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants