-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update layoutlib to v14.0.9 (Koala Feature Drop +) #1487
Conversation
962fc1c
to
5847477
Compare
cd2ed3e
to
694aa7c
Compare
0693c4e
to
625f370
Compare
625f370
to
5607758
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
// When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test. | ||
// When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1 | ||
// and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test. | |
// When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1 | |
// and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index. |
good context for a PR comment today. But it's not a controversial code change (worst case, it's defensive) and the code comment will likely grow stale if Compose implementation details change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I will move this to a PR comment for context.
// When using Dialogs in Compose, it seems that a WindowManager view gets added to the view group alongside the ComposeView under test.
// When our view under test is removed, compose will remove the WindowManager view first and then the ComposeView. But since the index of the view under test is 1
// and there are only 1 views in the ViewGroup when WindowManager is removed, it throws an invalid index.
d7d2e77
to
064b60a
Compare
@jrodbx curious, now that we are using the provided google artifacts for layoutlib, do you know if we can pull which version of AS corresponds with? |
AFAIK, there's no simple way to extract that programmatically. However, I have asked for that very mapping and an issue has been filed here. |
cool, +1'd the filed issue |
This PR contains the following updates:
14.0.8
->14.0.9
14.0.8
->14.0.9
14.0.8
->14.0.9
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.