Move plugin tests from testDebug to verifyPaparazziDebug to use same diffing execution path #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodbx
changed the title
jrodbx
force-pushed
the
jrod/2024-07-12/move-tests
branch
from
d9485b0 to
5297abf
Compare
There was a problem hiding this comment.
nit: looks like that App theme for this test may have changed. The navigation icons are different.
There was a problem hiding this comment.
Actually this might be expected after this change.
geoff-powell
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits.
The first is the main objective: moving a bunch of tests from
testDebugto usingverifyPaparazziDebugin order to wean off the bespoke ImageSubject test class. This requires moving golden images fromsrc/test/resourcestosrc/test/snapshots/imagesper the convention.In addition, this PR also:
Groups related tests into one:
And, extracts a new test
composeLeaksto separately run "testDebug", allowing its previous home (compose) to runverifyPaparazziDebugwithout the need for dummy golden images.