Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Communication Channels via TLS #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benjaminhettwer
Copy link

No description provided.

@benjaminhettwer benjaminhettwer requested a review from a team as a code owner August 13, 2024 08:23
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (67689c8) to head (73b9491).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   81.67%   80.16%   -1.51%     
==========================================
  Files          30       30              
  Lines        3323     3413      +90     
==========================================
+ Hits         2714     2736      +22     
- Misses        521      584      +63     
- Partials       88       93       +5     
Flag Coverage Δ
service 80.16% <ø> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67689c8...73b9491. Read the comment docs.

Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

Please have a look at the individual comments.

charts/ephemeral/templates/discovery.yaml Show resolved Hide resolved
charts/ephemeral/templates/discovery.yaml Outdated Show resolved Hide resolved
charts/ephemeral/templates/ephemeral.yaml Outdated Show resolved Hide resolved
charts/ephemeral/templates/network-controller.yaml Outdated Show resolved Hide resolved
charts/ephemeral/values.yaml Show resolved Hide resolved
pkg/ephemeral/io/feeder.go Outdated Show resolved Hide resolved
pkg/ephemeral/network/proxy.go Outdated Show resolved Hide resolved
pkg/types/types.go Outdated Show resolved Hide resolved
pkg/utils/os.go Outdated Show resolved Hide resolved
@sbckr
Copy link
Member

sbckr commented Sep 17, 2024

@benjaminhettwer btw. please add yourself to the NOTICE.md file

Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
@sbckr sbckr force-pushed the feature/secure-comm-channels branch from 80d7ec2 to ad0b89d Compare December 19, 2024 10:13
@sbckr sbckr force-pushed the feature/secure-comm-channels branch from 69fb33c to 73b9491 Compare December 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants