Fix PR comments

Signed-off-by: Benjamin Hettwer <[email protected]>

NOTICE.md

@@ -26,5 +26,6 @@ these files remains with the original authors.
 ### Robert Bosch GmbH
 
 - Becker Sebastian <[email protected]>
+- Hettwer Benjamin <[email protected]>
 - Raskin Vadim <[email protected]>
 - Trieflinger Sven <[email protected]>

charts/ephemeral/templates/discovery.yaml

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021-2023 - for information on the respective copyright owner
+# Copyright (c) 2021-2024 - for information on the respective copyright owner
 # see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 #
 # SPDX-License-Identifier: Apache-2.0
@@ -66,7 +66,7 @@ spec:
   ports:
     - protocol: TCP
       port: 8080
-      name: grpc-my
+      name: cs-tcp
       targetPort: 8080
 ---
 apiVersion: v1
@@ -99,7 +99,7 @@ spec:
 {{- if .Values.discovery.tls.enabled }}
     - port:
         number: 31400
-        name: grpc-my
+        name: cs-grpc
         protocol: HTTPS
       tls:
         mode: MUTUAL # enables mTLS on the Gateway
@@ -109,7 +109,7 @@ spec:
 {{- else }}
     - port:
         number: 31400
-        name: grpc-my
+        name: cs-grpc
         protocol: GRPC
       hosts:
         - "*"

charts/ephemeral/templates/ephemeral.yaml

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021-2023 - for information on the respective copyright owner
+# Copyright (c) 2021-2024 - for information on the respective copyright owner
 # see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 #
 # SPDX-License-Identifier: Apache-2.0

charts/ephemeral/templates/network-controller.yaml

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 - for information on the respective copyright owner
+# Copyright (c) 2021-2024 - for information on the respective copyright owner
 # see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 #
 # SPDX-License-Identifier: Apache-2.0

charts/ephemeral/values.yaml

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021-2023 - for information on the respective copyright owner
+# Copyright (c) 2021-2024 - for information on the respective copyright owner
 # see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 #
 # SPDX-License-Identifier: Apache-2.0

pkg/ephemeral/io/feeder.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2021-2023 - for information on the respective copyright owner
+// Copyright (c) 2021-2024 - for information on the respective copyright owner
 // see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 //
 // SPDX-License-Identifier: Apache-2.0

pkg/ephemeral/network/proxy.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2021-2023 - for information on the respective copyright owner
+// Copyright (c) 2021-2024 - for information on the respective copyright owner
 // see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 //
 // SPDX-License-Identifier: Apache-2.0

pkg/network-controller/controller/network/network_controller.go

@@ -171,9 +171,6 @@ func (r *ReconcileNetwork) Reconcile(request reconcile.Request) (reconcile.Resul
 	}
 
 	log.Info(fmt.Sprintf("Reconcile with the config:\n%+v", r.config))
-	if err != nil {
-		panic(err)
-	}
 
 	// Check if the gateway already exist, create it otherwise.
 

pkg/types/types.go

@@ -154,13 +154,6 @@ type DiscoveryClientTypedConfig struct {
 	ConnectTimeout time.Duration
 }
 
-// K8sSecret represents the structure containing key, cert, and CA cert
-type K8sSecret struct {
-	Key    string
-	Cert   string
-	CACert string
-}
-
 // OutputConfig defines how the output of the app execution is treated.
 type OutputConfig struct {
 	Type string `json:"type"`

pkg/utils/os.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2021 - for information on the respective copyright owner
+// Copyright (c) 2021-2024 - for information on the respective copyright owner
 // see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 //
 // SPDX-License-Identifier: Apache-2.0