-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser console plugin + update CONTRIBUTING.md #23
Open
haobrien
wants to merge
4
commits into
main
Choose a base branch
from
console-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0103d7a
feat: browser console plugin
haobrien 2d6c5b0
chore: add additional action items to CONTRIBUTING.md
haobrien 84c2278
Merge branch 'main' of github.com:capitalone/Stratum-Observability in…
haobrien 8070317
chore: add browser-console plugin to package.json; clean up plugin logic
haobrien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { BasePlugin } from '../../base'; | ||
import type { PluginFactory } from '../../types'; | ||
import { BrowserConsolePublisher } from './publisher'; | ||
|
||
/** | ||
* Browser Console plugin | ||
*/ | ||
export class BrowserConsolePlugin extends BasePlugin<never, never> { | ||
name = 'browserConsole'; | ||
publishers = [new BrowserConsolePublisher()]; | ||
} | ||
|
||
/** | ||
* Browser Console plugin factory function | ||
* | ||
* Use this function to instantiate the BrowserConsolePlugin when registering | ||
* this plugin within Stratum. | ||
*/ | ||
export const BrowserConsolePluginFactory: PluginFactory<BrowserConsolePlugin> = () => new BrowserConsolePlugin(); | ||
|
||
export * from './publisher'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { BaseEventModel, BasePublisher } from '../../base'; | ||
import { StratumSnapshot } from '../../types'; | ||
|
||
/** | ||
* Browser Console Publisher | ||
*/ | ||
export class BrowserConsolePublisher extends BasePublisher { | ||
name = 'browserConsole'; | ||
|
||
/** | ||
* Handle all event types generically, even those provided | ||
* by a separate plugin. | ||
*/ | ||
shouldPublishEvent(): boolean { | ||
return true; | ||
} | ||
|
||
/** | ||
* Required | ||
* Returns data from underlying events to utilize | ||
* in the publish step. | ||
* | ||
* In this case, we send the stringified event data to be logged in the console. | ||
*/ | ||
getEventOutput(_event: BaseEventModel, snapshot: StratumSnapshot): string { | ||
return JSON.stringify(snapshot.event); | ||
} | ||
|
||
/** | ||
* Required | ||
* Check if your publisher source is available (aka scripts installed, environment | ||
* is set up, etc.) | ||
* | ||
* In this case, we make sure that console.log() is accessible. | ||
*/ | ||
async isAvailable(): Promise<boolean> { | ||
return typeof console !== 'undefined'; | ||
} | ||
|
||
/** | ||
* Required | ||
* Send your content to the external publisher | ||
* | ||
* In this, case we publish the stringified event data to the console. | ||
*/ | ||
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ | ||
async publish(content: string): Promise<void> { | ||
console.log(`BrowserConsolePlugin: ${content}`); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
import { BasePublisher, StratumService } from '../../src'; | ||
import { | ||
BrowserConsolePlugin, | ||
BrowserConsolePluginFactory, | ||
BrowserConsolePublisher | ||
} from '../../src/plugins/browser-console'; | ||
import { CATALOG_METADATA, PRODUCT_NAME, PRODUCT_VERSION } from '../utils/constants'; | ||
import { getPublishers, restoreStratumMocks } from '../utils/helpers'; | ||
import { BASE_CATALOG } from '../utils/catalog'; | ||
|
||
describe('browser console plugin', () => { | ||
let stratum: StratumService; | ||
let plugin: BrowserConsolePlugin; | ||
let publisher: BasePublisher; | ||
|
||
beforeEach(() => { | ||
plugin = BrowserConsolePluginFactory(); | ||
stratum = new StratumService({ | ||
catalog: { items: BASE_CATALOG, ...CATALOG_METADATA }, | ||
plugins: [plugin], | ||
productName: PRODUCT_NAME, | ||
productVersion: PRODUCT_VERSION | ||
}); | ||
publisher = stratum.publishers[0]; | ||
}); | ||
|
||
afterEach(() => { | ||
restoreStratumMocks(); | ||
jest.restoreAllMocks(); | ||
}); | ||
|
||
it('should successfully publish from catalog', async () => { | ||
const result = await stratum.publish(1); | ||
expect(result).toBe(true); | ||
}); | ||
|
||
it('should initialize the BrowserConsole publisher', () => { | ||
expect(getPublishers(stratum)[0]).toBeInstanceOf(BrowserConsolePublisher); | ||
}); | ||
|
||
it('should publish and log events to the console', async () => { | ||
expect(publisher).toBeInstanceOf(BrowserConsolePublisher); | ||
|
||
const publishSpy = jest.spyOn(publisher, 'publish'); | ||
const consoleSpy = jest.spyOn(console, 'log'); | ||
|
||
let result = await stratum.publish(1); | ||
let expectedContent = `{"eventType":"${BASE_CATALOG[1].eventType}","id":${BASE_CATALOG[1].id}}`; | ||
let expectedLoggedMessage = `BrowserConsolePlugin: ${expectedContent}`; | ||
|
||
expect(result).toBe(true); | ||
expect(publishSpy).toHaveBeenCalledWith(expectedContent, expect.anything()); | ||
expect(consoleSpy).toHaveBeenCalledWith(expectedLoggedMessage); | ||
|
||
expectedContent = `{"eventType":"${BASE_CATALOG[2].eventType}","id":${BASE_CATALOG[2].id}}`; | ||
expectedLoggedMessage = `BrowserConsolePlugin: ${expectedContent}`; | ||
result = await stratum.publish(2); | ||
|
||
expect(result).toBe(true); | ||
expect(publishSpy).toHaveBeenCalledWith(expectedContent, expect.anything()); | ||
expect(consoleSpy).toHaveBeenCalledWith(expectedLoggedMessage); | ||
|
||
expect(publishSpy).toHaveBeenCalledTimes(2); | ||
expect(consoleSpy).toHaveBeenCalledTimes(2); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add browser-console to the
package.json
file so that it can be directly imported by consuming apps.