Add browser console plugin + update CONTRIBUTING.md #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erolunal
reviewed
Nov 25, 2024
| */ | ||
| /* eslint-disable-next-line @typescript-eslint/no-explicit-any */ | ||
| async publish(_content: any, snapshot: StratumSnapshot) { | ||
| console.log(snapshot.data); |
There was a problem hiding this comment.
I think we should send more data to the console as snapshot.data only contains the output from model.getData(). Other metadata like the tag ID or event type within the snapshot would also be useful.
There was a problem hiding this comment.
Updated! Changed the getEventOutput return value and updated the publish method accordingly. Thought that'd better show how they relate. It'll now publish to the console something like:
BrowserConsolePlugin: {"eventType":"eventTypeName","id":1}
| * Use this function to instantiate the BrowserConsolePlugin when registering | ||
| * this plugin within Stratum. | ||
| */ | ||
| export const BrowserConsolePluginFactory: PluginFactory<BrowserConsolePlugin> = () => new BrowserConsolePlugin(); |
There was a problem hiding this comment.
Add browser-console to the package.json file so that it can be directly imported by consuming apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 For new features and bugfixes, please create an issue first
✔️ Checklist
Please review our Contributor Docs for more details
npm version [patch, minor, major](considering (semantic versioning)[https://semver.org/#summary)) for a new release if neededrelease([VERSION]):⏩ Next steps: