New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Filter out internal and private metadata #82

Merged

aramovic79 merged 16 commits into main from feat/77-filter-out-metatata-where-visibility-is-internal-or-private

Nov 11, 2024

Contributor

aramovic79 commented Oct 24, 2024

No description provided.


          initial commit

9fb1c3b

aramovic79 linked an issue

that may be closed by this pull request

Filter out metatata where visibility=internal or =private #77

Closed

aramovic79 commented

View reviewed changes

lib/templates.js Outdated Show resolved Hide resolved

aramovic79 added 2 commits

November 5, 2024 16:33


          Merge branch 'main' of https://github.com/cap-js/ORD into feat/77-fil…

ff6dd18

…ter-out-metatata-where-visibility-is-internal-or-private


          filter non-public api resources

07aa35a

swennemers reviewed

View reviewed changes

lib/templates.js Show resolved Hide resolved

xmpl/srv/services.cds Outdated Show resolved Hide resolved

aramovic79 added 5 commits

November 6, 2024 16:57


          handle visibility on events, apis and packages; fix some tests as wel…

fdb7932

…l; also, minor refactoring done


          removal of logger propagation

6d378e5


          private and internal resource are not considered

128e494


          minor change

b0bd69e


          minor change

c99a4b3

aramovic79 commented

View reviewed changes

__tests__/__snapshots__/ordCdsrc.test.js.snap Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/__snapshots__/ordCdsrc.test.js.snap Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/__snapshots__/ordCdsrc.test.js.snap Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/__snapshots__/ordPackageJson.test.js.snap Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/ordCdsrc.test.js Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/ordCdsrc.test.js Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/unittest/__snapshots__/templates.test.js.snap Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/unittest/extendOrdWithCustom.test.js Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

__tests__/unittest/templates.test.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/constants.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/extendOrdWithCustom.js Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/ord.js Outdated Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/ord.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/ord.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/ord.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/templates.js Show resolved Hide resolved

aramovic79 commented

View reviewed changes

lib/templates.js Show resolved Hide resolved

aramovic79 linked an issue

that may be closed by this pull request

Fix: remove getPackageID() packageIds check #73

Closed

zongqichen reviewed

View reviewed changes

lib/ord.js Show resolved Hide resolved

lib/templates.js Outdated Show resolved Hide resolved

__tests__/__snapshots__/ordCdsrc.test.js.snap Outdated Show resolved Hide resolved

__tests__/__snapshots__/ordCdsrc.test.js.snap Outdated Show resolved Hide resolved

__tests__/ordCdsrc.test.js Outdated Show resolved Hide resolved

lib/ord.js Outdated Show resolved Hide resolved

lib/ord.js Show resolved Hide resolved

lib/templates.js Outdated Show resolved Hide resolved

lib/templates.js Outdated Show resolved Hide resolved

lib/templates.js Show resolved Hide resolved

zongqichen reviewed

View reviewed changes

lib/templates.js Show resolved Hide resolved

zongqichen reviewed

View reviewed changes

lib/templates.js Outdated Show resolved Hide resolved

zongqichen reviewed

View reviewed changes

lib/templates.js Show resolved Hide resolved

aramovic79 added 6 commits

November 8, 2024 10:45


          add unit tests for private and internal resources

4f4150c


          change the visibility of Admin and Catalog services; regenerate snaps…

67a004d

…hots


          add internal cinema-service

bfc8ae2


          remove the check if the package is undefined

992b48b


          minor change: remove un-needed comment

6c36856


          minor change: remove un-needed comment

8d9bf18

aramovic79 marked this pull request as ready for review

November 8, 2024 11:25

aramovic79 requested review from zongqichen, Fannon and swennemers

November 8, 2024 11:26

aramovic79 added 2 commits

November 8, 2024 17:28


          minor change: address review comment #82 (comment)

6cdf905


          address review comments

2820f9e

zongqichen approved these changes

View reviewed changes

Contributor

zongqichen left a comment

LGTM

aramovic79 merged commit 39ad47d into main

3 checks passed

aramovic79 deleted the feat/77-filter-out-metatata-where-visibility-is-internal-or-private branch

November 11, 2024 16:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet