Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove getPackageID() packageIds check #73

Closed
zongqichen opened this issue Oct 14, 2024 · 1 comment · Fixed by #82
Closed

Fix: remove getPackageID() packageIds check #73

zongqichen opened this issue Oct 14, 2024 · 1 comment · Fixed by #82
Assignees
Labels
bug Something isn't working

Comments

@zongqichen
Copy link
Contributor

In templates.js, the function _getPackageID() has strange check. We need to figure out why it will be failed the test if we remove it:

function _getPackageID(namespace, packageIds, resourceType) {
    //TODO: without this check, it will be failed in ordPackageJson.test.js, need to check why it is failing
    if (!(packageIds instanceof Set)) return;
    const packageIdsArray = Array.from(packageIds);
    return packageIdsArray.find((pkg) => pkg.includes("-" + resourceType)) || packageIdsArray.find((pkg) => pkg.includes(namespace));
}
@zongqichen zongqichen added the bug Something isn't working label Oct 14, 2024
@aramovic79 aramovic79 linked a pull request Nov 7, 2024 that will close this issue
@aramovic79 aramovic79 self-assigned this Nov 7, 2024
@zongqichen
Copy link
Contributor Author

Hi @aramovic79, do you know why it failed? Or what the root cause of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants