Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /ceph redesign #14498

Merged

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Nov 22, 2024

Done

  • Applied redesign as per doc and design
  • Drive by:
    • Bump Vanilla version

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-16343

@webteam-app
Copy link

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (5a97dae) to head (3d11f2e).
Report is 49 commits behind head on feature-rebrand-ceph.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-rebrand-ceph   #14498      +/-   ##
========================================================
+ Coverage                 69.64%   69.76%   +0.12%     
========================================================
  Files                       120      120              
  Lines                      3419     3426       +7     
  Branches                   1178     1181       +3     
========================================================
+ Hits                       2381     2390       +9     
+ Misses                     1013     1012       -1     
+ Partials                     25       24       -1     

@mattea-turic
Copy link
Collaborator

mattea-turic commented Nov 22, 2024

thank you @mtruj013 !

  • Could there be just one hr used here, as these two are essentially acting as an equal heights row
Screenshot 2024-11-22 at 14 57 13
  • I think I asked this before, but is it possible to have the ctas at the same level, like in the figma design – or is this a limitation of vanilla?
Screenshot 2024-11-22 at 15 09 15
  • On smaller screens, would it be possible to implement wrapping like this, for the items under "proven success with ceph storage" and "more choice, for your infrastructure"? Right now, they occupy too much space unless on desktop view

@mtruj013
Copy link
Contributor Author

@mattea-turic ready for you!

or is this a limitation of vanilla?

Honestly, all of the spacing on this component is a limitation of vanilla because the component itself doesn't actually exist on vanilla 🙂 Should match now though

@mattea-turic
Copy link
Collaborator

ty @mtruj013 !

as discussed on mm, if you could drop the images in the section "Proven success with Ceph storage" for smaller screens – and that's all :)

I'll +1 given this change will be made

@mtruj013 mtruj013 merged commit 6890f20 into canonical:feature-rebrand-ceph Nov 28, 2024
15 checks passed
@mtruj013 mtruj013 deleted the ceph-landing-rebrand branch November 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants