Code Suggestion for #14498 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly aligned cards with their CTAs
|
Thanks for this @muhammad-ali-pk! I think there might be some conflicting styles here breaking the grid a bit. I can keep playing around with it but given that this component is going to be officially upstreamed to vanilla soon I think it's better to refactor this accordingly then 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canonical#14498 Nice work levelling the cards + CTAs. However, if in future, any of the card is updated to add/remove a line (copy update), the CTA's will lose their alignment. This suggestion makes sure the cards and CTAs stay aligned, no matter the content.