[DPE-2674] Convert test_charm.py to pytest style testing instead of unittest #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 81.08% 80.96% -0.12%
==========================================
Files 10 10
Lines 2252 2259 +7
Branches 362 363 +1
==========================================
+ Hits 1826 1829 +3
- Misses 351 354 +3
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. |
dragomirp
reviewed
Apr 5, 2024
dragomirp
reviewed
Apr 5, 2024
Comment on lines
+50
to
+55
| # This causes every test defined in this file to run 2 times, each with | ||
| # charm.JujuVersion.has_secrets set as True or as False | ||
| @pytest.fixture(params=[True, False], autouse=True) | ||
| def _has_secrets(request, monkeypatch): | ||
| monkeypatch.setattr("charm.JujuVersion.has_secrets", PropertyMock(return_value=request.param)) | ||
| return request.param |
There was a problem hiding this comment.
Going forward we should change the other tests and move this in conftest, but it can happen in a follow up PR.
dragomirp
approved these changes
Apr 5, 2024
taurus-forever
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Great work, @lucasgameiroborges! I left some comments in the code. Please take a look and evaluate what makes sense and what doesn't. Thanks!
marceloneppel
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow tests to run with
jujuVersion.has_secretsboth enabled and disabled. Move away fromunittest.TestCase.Structure
Tests are largely unaltered, with few exceptions:
test_delete_passwordgot removed andtest_delete_existing_password_secretsnow handles both versions with and without secrets.test_update_certificategot removed andtest_update_certificate_secretsnow handles both versions with and without secrets.test_migration_from_databagandtest_migration_from_single_secretgot adapted in order to run only ifhas_secrets == Truesince they test migration from databag to secrets.Only two global pytest fixtures are used:
harnessand_has_secrets. Especific patches are kept inside their respective tests.Testing