Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tls access relation #30

Merged
merged 5 commits into from
Sep 20, 2024
Merged

feat: tls access relation #30

merged 5 commits into from
Sep 20, 2024

Conversation

kayra1
Copy link
Collaborator

@kayra1 kayra1 commented Aug 27, 2024

Description

This change introduces the notary tls requires endpoint for certificate providers to provide an access certificate.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review September 16, 2024 16:41
@kayra1 kayra1 requested a review from a team as a code owner September 16, 2024 16:41
Copy link
Member

@DanielArndt DanielArndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a few minor comments.

tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from DanielArndt September 19, 2024 08:18
tests/integration/test_charm.py Outdated Show resolved Hide resolved
@kayra1 kayra1 enabled auto-merge (squash) September 20, 2024 09:05
@kayra1 kayra1 merged commit 36cca84 into main Sep 20, 2024
8 checks passed
@kayra1 kayra1 deleted the access branch September 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants