Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implements the requirer side of the ingress integration #31

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented Aug 29, 2024

Description

  • Adds the ingress and cert-transfer integrations
  • Fetches the libs
  • Adds integration test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saltiyazan saltiyazan requested a review from a team as a code owner August 29, 2024 08:06
kayra1
kayra1 previously approved these changes Aug 29, 2024
@saltiyazan
Copy link
Contributor Author

This won't work if we merge it right away, it needs the tls integrations to be merged first, I'll make it a draft until then.

@saltiyazan saltiyazan marked this pull request as draft August 29, 2024 10:09
@kayra1 kayra1 dismissed their stale review August 29, 2024 10:15

needs rereview

@saltiyazan saltiyazan marked this pull request as draft September 27, 2024 07:11
@saltiyazan saltiyazan force-pushed the TLSENG-46 branch 2 times, most recently from 53f1025 to 969a0e9 Compare October 10, 2024 12:04
@saltiyazan saltiyazan marked this pull request as ready for review October 11, 2024 07:51
@saltiyazan saltiyazan requested review from kayra1 and a team October 11, 2024 07:51
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming the small typo fixes suggested are included.

tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
@saltiyazan saltiyazan merged commit e6f8b51 into main Oct 14, 2024
5 checks passed
@saltiyazan saltiyazan deleted the TLSENG-46 branch October 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants