Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microk8s inspect incorrectly logs the 'ip addr' and 'ip route' system commands. #4694

Conversation

countravioli
Copy link

@countravioli countravioli commented Oct 2, 2024

In the inspect report, the commands 'ip addr' and 'ip route' were both being written to the file 'ip-addr' file.

The 'ip route' command was run second so the result was

  • misleading output in the ip-addr file actually being from 'ip-route'
  • missing the output from 'ip-addr'."

Summary

'ip addr' command will generate the 'ip-addr' file for output Corrected
'ip route' command will generate the 'ip-route' file New

Changes

One liner, redirect the output of 'ip route' to 'ip-route' file.

Testing

no testing, seemed very straight forward.

Possible Regressions

Anyone programmatically running a microk8s inspect report on failure and parsing the output of this file would need to change their system to use the "ip-route" file.

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

n/a

…h being written to the file 'ip-addr'. The 'ip route' command was run second so the result was A) a misleading output in the ip-addr file actually being from 'ip-route' and missing the output from 'ip-addr'.
@maci3jka maci3jka self-assigned this Oct 23, 2024
Copy link
Contributor

@maci3jka maci3jka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @countravioli!

@maci3jka
Copy link
Contributor

hey @countravioli do you have Launchpad account? What is its handler?

@countravioli
Copy link
Author

@maci3jka - same as github "countravioli". I did go through the docs on that, thought it was linked up. Sorry if I missed something.

@maci3jka
Copy link
Contributor

maci3jka commented Oct 23, 2024

@maci3jka - same as github "countravioli". I did go through the docs on that, thought it was linked up. Sorry if I missed something.

@countravioli could you provide URL to your Launchpad account? You can find it by clicking on your name in the top right corner

@countravioli
Copy link
Author

@maci3jka - hmm, maybe I didn't complete part of the process. I had a login at "login.launchpad.net" but hadn't been to launchpad.net yet.

https://launchpad.net/~countravioli

@maci3jka
Copy link
Contributor

@maci3jka - hmm, maybe I didn't complete part of the process. I had a login at "login.launchpad.net" but hadn't been to launchpad.net yet.

https://launchpad.net/~countravioli

@countravioli is your mail in launchpad set to [email protected]? This mail was the author of the commit

@maci3jka
Copy link
Contributor

@maci3jka - hmm, maybe I didn't complete part of the process. I had a login at "login.launchpad.net" but hadn't been to launchpad.net yet.
https://launchpad.net/~countravioli

@countravioli is your mail in launchpad set to [email protected]? This mail was the author of the commit

@countravioli have you managed to check the mail?

@maci3jka maci3jka mentioned this pull request Nov 22, 2024
3 tasks
@maci3jka maci3jka closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants