Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect ip route fix #4752

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Inspect ip route fix #4752

merged 1 commit into from
Nov 22, 2024

Conversation

maci3jka
Copy link
Contributor

Summary

Fixes typo in the output of the ip route command when running microk8s inspect
Inspired by /pull/4694

Changes

fix in scripts/inspect.sh

Testing

manual test

Possible Regressions

no

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

@maci3jka maci3jka requested a review from a team November 22, 2024 11:39
addyess
addyess approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, nice catch

@addyess addyess merged commit cb00e90 into master Nov 22, 2024
10 of 11 checks passed
@addyess addyess deleted the KU-1884/inspect-ip-route-fix branch November 22, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maci3jka @addyess