-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: Switch to ST124 "shorthand notation" syntax in charmcraft.yaml #258
Draft
carlcsaposs-canonical
wants to merge
7
commits into
charmcraft-3
Choose a base branch
from
charmcraftst124
base: charmcraft-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables building & releasing multi-base charms with 24.04 in a single charmcraft.yaml and git branch Integration testing is not supported on multiple bases—it is currently only supported on 22.04
Adds support for core24 `platforms` in snapcraft.yaml
Will not be merged until coordinated charmcraft 3 migration (https://chat.canonical.com/canonical/pl/wekd7r4eqtdn7mxhgxgej8zzsr) Depends on #258 |
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever,
shayancanonical and
sinclert-canonical
December 19, 2024 10:47
Comment on lines
+9
to
+10
# TODO: use permalink | ||
warnings.warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will address right before merging (when version number for permalink can be predicted)
carlcsaposs-canonical
changed the title
breaking: Support ST124 shorthand notation syntax in charmcraft.yaml
breaking: Switch to ST124 "shorthand notation" syntax in charmcraft.yaml
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables building & releasing multi-base charms with 24.04 in a single charmcraft.yaml and git branch
Integration testing is not supported on multiple bases—it is currently only supported on 22.04
Breaking changes
pytest-operator-cache
(which overridesops_test.build_charm
from pytest-operator) now assumes 22.04 baseDeprecation notice
pytest-operator-cache
is deprecated & will be removed in a future release