Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Switch to ST124 "shorthand notation" syntax in charmcraft.yaml #253

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical commented Dec 5, 2024

Warning

This branch is in beta, not merged, and not part of the public interface. It is subject to breaking changes or removal at anytime.

charmcraft

Enables building & releasing multi-base charms with 24.04 in a single charmcraft.yaml and git branch

Integration testing is not supported on multiple bases—it is currently only supported on 22.04

Usage

  1. Update charmcraft.yaml following https://github.com/canonical/data-platform-workflows/blob/beta-charmcraftst124/.github/workflows/build_charm.md#required-charmcraftyaml-syntax
  2. Ensure that all data-platform-workflows dependencies (workflows, python packages) are on v24.0.0
  3. Use this PR's branch for the build_charm.yaml workflow
    uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@beta-charmcraftst124
  4. Use this PR's branch for the release_charm.yaml workflow
    uses: canonical/data-platform-workflows/.github/workflows/release_charm.yaml@beta-charmcraftst124
  5. Use this PR's branch for the pytest-operator-cache plugin. Integration testing is currently only supported on 22.04
    pytest-operator-cache = {git = "https://github.com/canonical/data-platform-workflows", branch = "beta-charmcraftst124", subdirectory = "python/pytest_plugins/pytest_operator_cache"}

To build the charm on your local machine, use charmcraftst124: https://github.com/canonical/charmcraftst124

snapcraft

Enables building & releasing snaps with base: core24 and platforms

Usage

  1. Ensure supported snapcraft.yaml syntax is used https://github.com/canonical/data-platform-workflows/blob/beta-charmcraftst124/.github/workflows/build_snap.md#supported-platforms-and-architectures-syntax-in-snapcraftyaml
  2. Ensure that all data-platform-workflows dependencies (workflows, python packages) are on v24.0.0
  3. Use this PR's branch for the build_snap.yaml workflow
    uses: canonical/data-platform-workflows/.github/workflows/build_snap.yaml@beta-charmcraftst124
  4. Use this PR's branch for the release_snap.yaml workflow
    uses: canonical/data-platform-workflows/.github/workflows/release_snap.yaml@beta-charmcraftst124

@carlcsaposs-canonical
Copy link
Contributor Author

testing on canonical/mysql-router-k8s-operator#340

@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Dec 5, 2024

release on k8s broken with cc3, testing release on vm with cc3 on canonical/mysql-router-operator#192

token issue on mysql router vm, testing release on k8s with cc2 https://github.com/canonical/mysql-router-k8s-operator/actions/runs/12181700518/job/33978950746?pr=340

Enables building & releasing multi-base charms with 24.04 in a single charmcraft.yaml and git branch

Integration testing is not supported on multiple bases—it is currently only supported on 22.04
Adds support for core24 `platforms` in snapcraft.yaml
@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Dec 6, 2024

testing snap on canonical/charmed-postgresql-snap#69

@carlcsaposs-canonical
Copy link
Contributor Author

Will be superseded by #258 during coordinated charmcraft 3 migration (https://chat.canonical.com/canonical/pl/wekd7r4eqtdn7mxhgxgej8zzsr)

Keeping open for now to preserve branch for people that are using this branch for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant