Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource exchange #109

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Datasource exchange #109

merged 11 commits into from
Dec 10, 2024

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Dec 3, 2024 •
edited
Loading

grafana_datasource_exchange reference implementation library

Rebase on main after #108 is merged

@PietroPasotti PietroPasotti requested a review from a team as a code owner December 3, 2024 14:38
This was referenced Dec 3, 2024
Merged
Merged
Base automatically changed from generalize-interfaces to main December 4, 2024 11:04
@PietroPasotti PietroPasotti mentioned this pull request Dec 4, 2024
Merged
4 tasks
michaeldmitry
michaeldmitry reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@michaeldmitry michaeldmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic looks good to me :) few minor comments

src/cosl/interfaces/datasource_exchange.py Outdated Show resolved Hide resolved
src/cosl/interfaces/datasource_exchange.py Outdated Show resolved Hide resolved
src/cosl/interfaces/datasource_exchange.py Outdated Show resolved Hide resolved
michaeldmitry
michaeldmitry approved these changes Dec 10, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/cosl/interfaces/datasource_exchange.py Outdated Show resolved Hide resolved
tests/test_datasource_exchange.py Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit 8ae974b into main Dec 10, 2024
6 of 7 checks passed
@PietroPasotti PietroPasotti deleted the datasource_exchange branch December 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldmitry michaeldmitry michaeldmitry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PietroPasotti @michaeldmitry