Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana datasource exchange #207

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Dec 3, 2024

This PR adds a new internal relation interface called grafana_datasource_exchange.
Its purpose is to exchange grafana datasource UIDs between applications that have received one over grafana_datasource.

This interface is rather atypical in that it's symmetric (directionality doesn't matter and the schemas are mirrored).

Tandem PRs:

@PietroPasotti PietroPasotti marked this pull request as ready for review December 3, 2024 15:03
Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of minor suggestions - I think we shouldn't be using names of tools in the type section but rather use metrics / logs / traces. Other than that it looks good to me :)

@PietroPasotti PietroPasotti force-pushed the grafana_datasource_exchange branch from 9f16345 to 4c118b0 Compare December 4, 2024 11:26
@PietroPasotti PietroPasotti merged commit 539fa56 into main Dec 4, 2024
7 checks passed
@PietroPasotti PietroPasotti deleted the grafana_datasource_exchange branch December 4, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants