-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana datasource exchange #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmkay
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of minor suggestions - I think we shouldn't be using names of tools in the type
section but rather use metrics / logs / traces. Other than that it looks good to me :)
interfaces/grafana_datasource_exchange/v0/interface_tests/test_provider.py
Outdated
Show resolved
Hide resolved
interfaces/grafana_datasource_exchange/v0/interface_tests/test_provider.py
Outdated
Show resolved
Hide resolved
interfaces/grafana_datasource_exchange/v0/interface_tests/test_provider.py
Outdated
Show resolved
Hide resolved
interfaces/grafana_datasource_exchange/v0/interface_tests/test_provider.py
Outdated
Show resolved
Hide resolved
simskij
approved these changes
Dec 4, 2024
PietroPasotti
force-pushed
the
grafana_datasource_exchange
branch
from
December 4, 2024 11:26
9f16345
to
4c118b0
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new internal relation interface called
grafana_datasource_exchange
.Its purpose is to exchange grafana datasource UIDs between applications that have received one over
grafana_datasource
.This interface is rather atypical in that it's symmetric (directionality doesn't matter and the schemas are mirrored).
Tandem PRs: