-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Element Templates Runtime Versions #4744
Conversation
4beec19
to
edda88f
Compare
Styles for Incompatible button are missing, but this will be fixed with dependencies update in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we / should we test this?
Styles problem is fixed with update to
The test suite for modeling features is quite slim. Do we want to work on extending it as part of this PR? |
cc. @lmbateman for final look at the UI. |
Let's ensure this does not break accidentally in the future. I don't care which path we take to accomplish this 🙂 |
Will resolve conflicts now, and test manually. |
Rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine.
@jarekdanielak consider to follow-up (in any way) with this.
Checked using ✅ Both buttons look good In general, it looks great to me. Two very minor items to think about:
|
@lmbateman the feature is already merged, but I will save your comment as a follow up for later. Thanks for the feedback! |
Proposed Changes
Integrate element templates runtime version compatibility.
Camunda 8 BPMN editor will now pass current runtime version to element templates module. If template is incompatible, warning will be shown in properties panel and problems panel.
To try it out, use the new "Compatibility test" template from
cloud-samples
and try changing template version in XML or Camunda version.Closes #4617
Closes #4648
Closes #4530
Closes #4749
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}