-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change incompatible template button color #4766
Comments
@lmbateman can you provide more context? |
To be clear, the WCAG contrast success criteria are AA-level, and the Modeler is only required to meet A-level success criteria, so technically, the button meets our contractual requirements. Having said that, fixing it is the right thing to do. Background: We chose these button colors because:
Going forward, we have a couple of options:
|
Plus, users are unlikely to see two of our buttons next to each other, and unlikely to notice/remember the font color from one to the next (and also unlikely to care, I think :) ). My main concern is with ease of implementation, but if that's not an issue, then let's consider changing the font color instead of the button color. |
I'd be happy to help with this task as part of my open source contribution |
@BDFL669 thanks for showing interest in contributing! We haven't agreed on exact colors yet, so we can't jump to implementation right away, but please feel free to submit your proposals for the UI here. 😊 |
What should we do?
The orange button for an incompatible template in properties panel is not meeting the accessibility criteria.
Why should we do it?
Change it to a different color, fully accessible (and good looking!).
Extra
Suggestions from this comment could be added along with this.
The text was updated successfully, but these errors were encountered: