fix: set document title #4377
Merged
fix: set document title #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4376
|
This Pull Request targets Consider targeting |
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
nikku
reviewed
Jun 18, 2024
| @@ -419,7 +419,6 @@ app.createEditorWindow = function() { | |||
| const windowOptions = { | |||
| resizable: true, | |||
| show: false, | |||
| title: 'Camunda Modeler' + getTitleSuffix(app.metadata.version), | |||
There was a problem hiding this comment.
I personally found this useful, why not keep it?
There was a problem hiding this comment.
It's a duplicate of
There was a problem hiding this comment.
If we keep the code above, we set the title in two places:
- main process
- HTML
But on MacOS the HTML part takes precedence.
There was a problem hiding this comment.
Long term, we could consider adding context to the title, e.g. the current tab. But it's outside of the scope of the linked issue.
There was a problem hiding this comment.
OK, let's decide here and now that we ditch dev tag, and if we ever add it (again), then we do it inside the app.
nikku
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4376
Proposed Changes
This PR replaces the main process code used for the window title with an HTML
<title>tag. The content is hard-coded as "Camunda Modeler" in contrast to the old solution where we added "(dev)" for dev mode, but this piece of information is already represented in the bottom-right "what's new" button. The main advantage of the current solution is that the a11y tools won't report missing title anymore.Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}