Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set window title via HTML #4376

Closed
barmac opened this issue Jun 18, 2024 · 1 comment · Fixed by #4377
Closed

Set window title via HTML #4376

barmac opened this issue Jun 18, 2024 · 1 comment · Fixed by #4377
Assignees
@barmac
Labels
a11y
Milestone
M78

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 18, 2024 •
edited
Loading

What should we do?

Add title to the document to satisfy the a11y tool.

Why should we do it?

We don't want the tool to complain; it's not an a11y problem because the title is set via a different API (Electron Browser Window).

Child of https://github.com/bpmn-io/internal-docs/issues/909
@barmac barmac self-assigned this Jun 18, 2024
@barmac barmac added the ready Ready to be worked on label Jun 18, 2024
barmac added a commit that referenced this issue Jun 18, 2024
@barmac
fix: set document title
fb856b6 
Closes #4376
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 18, 2024
@barmac barmac mentioned this issue Jun 18, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 18, 2024
@barmac barmac added this to the M78 milestone Jun 18, 2024
@barmac barmac added the a11y label Jun 18, 2024
barmac added a commit that referenced this issue Jun 18, 2024
@barmac
fix: set document title
5592f1e 
Closes #4376
@barmac
Copy link
Collaborator Author

barmac commented Jun 18, 2024

Closed via #4377

@barmac barmac closed this as completed Jun 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 18, 2024
@marstamm marstamm mentioned this issue Jun 19, 2024
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
a11y
Projects
None yet
Milestone
M78
Development

Successfully merging a pull request may close this issue.

fix: set document title camunda/camunda-modeler
1 participant
@barmac