Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(webapps): use HeroDev libraries #4734

Merged
merged 9 commits into from
Nov 14, 2024
Merged

chore(webapps): use HeroDev libraries #4734

merged 9 commits into from
Nov 14, 2024

Conversation

venetrius
Copy link
Member

related to: #4549

@venetrius venetrius added the ci:no-build Prevents any CI stage from running. label Oct 18, 2024
@venetrius venetrius self-assigned this Oct 18, 2024
@venetrius venetrius mentioned this pull request Oct 18, 2024
Closed
1 task
@venetrius venetrius added ci:e2e Runs the frontend end-to-end tests. ci:webapp-integration Runs the webapp integration builds. and removed ci:no-build Prevents any CI stage from running. labels Oct 18, 2024
@venetrius venetrius force-pushed the 4549-use-herodev-libraries branch 4 times, most recently from 8503d54 to efa154d Compare October 21, 2024 13:51
tasso94
tasso94 reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is the name of the company HeroDev or HeroDevs?

@venetrius venetrius force-pushed the 4549-use-herodev-libraries branch from 4efb0f7 to 5deb396 Compare November 12, 2024 12:44
@venetrius
Copy link
Member Author

❓ Is the name of the company HeroDev or HeroDevs?

Updated changes to use HeroDevs consistently

@venetrius venetrius requested a review from tasso94 November 13, 2024 07:29
tasso94
tasso94 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job. 👍

I looked through the deps.js third-party bundle and deps.js.LICENSE.txt to ensure the HeroDevs libraries are used. All good 👍

@venetrius venetrius force-pushed the 4549-use-herodev-libraries branch from f8bf452 to 4b23b4c Compare November 14, 2024 09:09
@venetrius
Copy link
Member Author

Had to push one more commit to make it work with free style jobs. Added comment to issue with more details: #4549 (comment)

@venetrius venetrius requested a review from tasso94 November 14, 2024 13:22
@venetrius venetrius merged commit 991b964 into master Nov 14, 2024
4 of 5 checks passed
@venetrius venetrius deleted the 4549-use-herodev-libraries branch November 14, 2024 15:35
@venetrius
Copy link
Member Author

Reverting as to give time to legal to review HeroDevs terms and conditions.

venetrius added a commit that referenced this pull request Nov 25, 2024
@venetrius
Revert "chore(webapps): use HeroDev libraries (#4734)"
4733d04 
This reverts commit 991b964.
@venetrius venetrius mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasso94 tasso94 tasso94 approved these changes

Assignees

@venetrius venetrius

Labels
ci:e2e Runs the frontend end-to-end tests. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venetrius @tasso94