Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Herodevs libraries #4549

Closed
30 tasks done
tasso94 opened this issue Aug 21, 2024 · 7 comments
Closed
30 tasks done

Use Herodevs libraries #4549

tasso94 opened this issue Aug 21, 2024 · 7 comments
Assignees
Labels

Comments

@tasso94
Copy link
Member

tasso94 commented Aug 21, 2024

Acceptance Criteria (Required on creation)

  • Bump bootstrap to a version > 3.4.1.
  • Bump angular-ui-bootstrap to a version > 2.5.6.
  • Bump angular-translate to a version > 2.19.0.
  • Bump angular-moment to a version > 1.3.0.
  • Ensure AngularJS uses Herodevs libs as well.

Update team docs: https://confluence.camunda.com/pages/viewpage.action?pageId=110241054

Hints

Links

Breakdown

Pull Requests

  1. ci:e2e ci:webapp-integration
    venetrius
  2. venetrius
  3. venetrius
  4. venetrius
  5. venetrius

Revert changes

  1. ci:e2e
    venetrius

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@tasso94 tasso94 added the type:task Issues that are a change to the project that is neither a feature nor a bug fix. label Aug 21, 2024
@tasso94 tasso94 changed the title Bump bootstrap to a version > 3.4.1 Bump Bootstrap to a version > 3.4.1 Sep 25, 2024
@toco-cam toco-cam changed the title Bump Bootstrap to a version > 3.4.1 Use Herodevs Bootstrap libraries Sep 25, 2024
@tasso94 tasso94 changed the title Use Herodevs Bootstrap libraries Use Herodevs libraries Oct 2, 2024
@venetrius
Copy link
Member

venetrius commented Oct 14, 2024

Conversion w @tasso94
We need to update to the new token in vault.
First step could be to update the secret in vault also update the xlts namespace to herodev.
And then a next step is to add bootstrap.

venetrius added a commit that referenced this issue Oct 18, 2024
venetrius added a commit that referenced this issue Oct 18, 2024
venetrius added a commit that referenced this issue Oct 21, 2024
venetrius added a commit that referenced this issue Oct 22, 2024
@venetrius
Copy link
Member

venetrius commented Oct 28, 2024

Also update in repo:
https://github.com/camunda/jenkins-job-dsl-seed-jobs/
it might be that some update needed from infra team as well.
Can customise this build with the branch but also need to check if need to customise upstream projects
https://release.cambpm.camunda.cloud/view/Release-Test/job/7.23/job/7.23-TEST-RELEASE-start-camunda-bpm-release/build?delay=0sec
Don't merge to maintenance version before validating release test jobs work

Could also run a test release job for 7.22 to see that this is a problem (can ask Yana)

Update

Checked https://github.com/camunda/jenkins-job-dsl-seed-jobs/, it references 3 paramaters regarding this ticket:
XLTS_REGISTRY_AUTH_TOKEN
XLTS_REGISTRY
XLTS_AUTH_TOKEN
I assume XLTS_REGISTRY_AUTH_TOKEN is used to fetch the latter two.
The location where these secrets are stored changed but the keys (XLTS_REGISTRY, XLTS_AUTH_TOKEN) did not. No change is required in seed-jobs. A test will tell if any upstream projects needs an update.

@venetrius
Copy link
Member

@tasso94 added issue to migrate remaining maintanance version to HeroDevs as well: #4784

@venetrius
Copy link
Member

reached out to infra: https://camunda.slack.com/archives/C5AHF1D8T/p1731402410298249

@venetrius venetrius assigned tasso94 and unassigned venetrius Nov 13, 2024
venetrius added a commit that referenced this issue Nov 14, 2024
venetrius added a commit that referenced this issue Nov 14, 2024
venetrius added a commit that referenced this issue Nov 14, 2024
venetrius added a commit that referenced this issue Nov 14, 2024
venetrius added a commit that referenced this issue Nov 14, 2024
@venetrius
Copy link
Member

venetrius commented Nov 14, 2024

For our free style jobs all injected credentials are placed in this path products/cambpm/ci/jenkins.
This means XLTS.dev and HeroDevs credentials can't have the same names.
Refactored in the code:
XLTS_REGISTRY => HERODEVS_REGISTRY
XLTS_AUTH_TOKEN => HERODEVS_AUTH_TOKEN

@tasso94
Copy link
Member Author

tasso94 commented Nov 14, 2024

@venetrius, looks good to me. Let's merge the PRs into the master branches, run the release seed jobs (triggered automatically), and see the result of the test release job for 7.23. Afterwards, I would do the backporting

@venetrius venetrius assigned tasso94 and venetrius and unassigned venetrius and tasso94 Nov 25, 2024
@tasso94 tasso94 assigned venetrius and unassigned tasso94 Nov 26, 2024
@venetrius venetrius assigned tasso94 and unassigned venetrius Nov 26, 2024
@tasso94 tasso94 assigned venetrius and unassigned tasso94 Nov 26, 2024
venetrius added a commit to camunda/camunda-docs-manual that referenced this issue Nov 26, 2024
venetrius added a commit to camunda/camunda-docs-manual that referenced this issue Nov 26, 2024
venetrius added a commit to camunda/camunda-docs-manual that referenced this issue Nov 26, 2024
venetrius added a commit to camunda/camunda-docs-manual that referenced this issue Nov 26, 2024
@venetrius venetrius assigned tasso94 and unassigned venetrius Nov 26, 2024
@tasso94 tasso94 assigned venetrius and unassigned tasso94 Nov 27, 2024
@venetrius
Copy link
Member

@gbetances089 No functional changes in this issue. Smoke tested that web apps work after changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants