Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user story and fix file name #129

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction
  • documentation

What this PR does / why we need it:

Update User Story and fix file name.
Related to Pr #125 and Issue #122

Closing previous PR as I couldn't include new commits.

@fernandopradocabrillo
Copy link
Collaborator Author

@gregory1g in this PR are included the changes suggested to @jgarciahospital

@gregory1g
Copy link

lgfm

@fernandopradocabrillo
Copy link
Collaborator Author

Hi @AxelNennker please take a look so we can merge this one. Thanks!

(@hdamker let me ping you just in case we have to merge this) 👀

@AxelNennker
Copy link
Collaborator

Why is numberverification changing from Customer:Foobar to ASP:Fobar?

There does not seem to be any guideline in Camara and user stories are somewhat free-form, but shouldn't we stick to Customer like the user stories of other subprojects e.g. https://github.com/camaraproject/SimSwap/blob/main/documentation/API_documentation/SIM-Swap_check_User_Story.md

Why mention "channel partner"?

@jgarciahospital
Copy link
Collaborator

Why is numberverification changing from Customer:Foobar to ASP:Fobar?

There does not seem to be any guideline in Camara and user stories are somewhat free-form, but shouldn't we stick to Customer like the user stories of other subprojects e.g. https://github.com/camaraproject/SimSwap/blob/main/documentation/API_documentation/SIM-Swap_check_User_Story.md

Why mention "channel partner"?

Both User Stories are now aligned (SIM Swap and Number Verification), let's see if for further versions we have a CAMARA strict aligned format.

Changes applied are ok for me.

bigludo7
bigludo7 previously approved these changes Aug 22, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ECORMAC
Copy link
Collaborator

ECORMAC commented Aug 23, 2024

In the summary we use the term "phone", should we change to "device", can't find the term "phone" in the commonalities glossary.

@ECORMAC
Copy link
Collaborator

ECORMAC commented Aug 23, 2024

In "Pre-Conditions" number 4, should we give a "hint" on the mechs used (e.g. standard "OIDC Authorization Code Flow")?

@fernandopradocabrillo
Copy link
Collaborator Author

In the summary we use the term "phone", should we change to "device", can't find the term "phone" in the commonalities glossary.

mm I don't know since we also don't manage the concept device in this API

@bigludo7 bigludo7 merged commit d3030fe into camaraproject:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants