-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user story and fix file name #129
Update user story and fix file name #129
Conversation
@gregory1g in this PR are included the changes suggested to @jgarciahospital |
lgfm |
Hi @AxelNennker please take a look so we can merge this one. Thanks! (@hdamker let me ping you just in case we have to merge this) 👀 |
documentation/API_documentation/NumberVerification_device_phone_number_User_Story.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/NumberVerification_device_phone_number_User_Story.md
Outdated
Show resolved
Hide resolved
Why is numberverification changing from There does not seem to be any guideline in Camara and user stories are somewhat free-form, but shouldn't we stick to Why mention "channel partner"? |
Both User Stories are now aligned (SIM Swap and Number Verification), let's see if for further versions we have a CAMARA strict aligned format. Changes applied are ok for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
documentation/API_documentation/NumberVerification_verify_User_Story.md
Outdated
Show resolved
Hide resolved
In the summary we use the term "phone", should we change to "device", can't find the term "phone" in the commonalities glossary. |
In "Pre-Conditions" number 4, should we give a "hint" on the mechs used (e.g. standard "OIDC Authorization Code Flow")? |
documentation/API_documentation/NumberVerification_device_phone_number_User_Story.md
Outdated
Show resolved
Hide resolved
…e_number_User_Story.md Co-authored-by: Axel Nennker <[email protected]>
…_Story.md Co-authored-by: Axel Nennker <[email protected]>
mm I don't know since we also don't manage the concept device in this API |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Update User Story and fix file name.
Related to Pr #125 and Issue #122
Closing previous PR as I couldn't include new commits.