Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release r1.1 with number-verification 1.0.0-rc.1 #126

Merged
merged 24 commits into from
Aug 16, 2024
Merged

Conversation

hdamker
Copy link
Contributor

@hdamker hdamker commented Jul 29, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

Note: this PR from the branch used for #121 that was closed because of wrong target branch.

What this PR does / why we need it:

Generation of first release-candidate for NumberVerification API

This first release candidate r1.1 contains the definition and documentation of the release-candidate of the NumberVerification API v1.0.0-rc.1.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented Jul 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.59s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.74s
✅ YAML yamllint 1 0 0.3s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor Author

hdamker commented Jul 29, 2024

NOTE: I had already previously reviewed in context of #121. Ready for final review by @camaraproject/release-management_maintainers

@hdamker hdamker requested a review from a team July 29, 2024 15:35
Copy link
Contributor Author

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to reflect the current status correctly within the API Readiness Checklist.

In case #124 or #129 will be merged before the pre-release, the lines can be accordingly updated.

@hdamker hdamker changed the title Release of API version 1.0.0-rc.1 Release r1.1 with number-verify 1.0.0-rc.1 Aug 8, 2024
@hdamker hdamker changed the title Release r1.1 with number-verify 1.0.0-rc.1 Release r1.1 with number-verification 1.0.0-rc.1 Aug 8, 2024
AxelNennker
AxelNennker previously approved these changes Aug 8, 2024
@fernandopradocabrillo
Copy link
Collaborator

@hdamker do we have anything pending in this PR?

@hdamker
Copy link
Contributor Author

hdamker commented Aug 13, 2024

@hdamker do we have anything pending in this PR?

@fernandopradocabrillo The review from Release Management is missing ... as I created the PR I don't want to do it myself. @soadeyemo has assigned the review issue (camaraproject/ReleaseManagement#67) to himself. He is on vacation until Wednesday, so I expect he will pick it up afterwards.

README.md Outdated Show resolved Hide resolved
Corrected raw content links
…hecklist.md


set "Test result statement" from "N" to "tbd".
CHANGELOG.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Contributor Author

hdamker commented Aug 16, 2024

@AxelNennker @fernandopradocabrillo due to unavailability of other Release Management team members I have also done the final review on behalf of Release Management and have done also already the changes for the findings:

  • no comments on the API definition file
  • Test definition file: PR Numberverify verify Test definition #124 still open - need to be done before M4 (which is due as release PR on August 26th!)
  • CHANGELOG.md: corrected links to raw YAML file
  • README.md: corrected links to raw YAML file
  • API Readiness Checklist: item 9 "Test result statement" is mandatory, set to "tbd". Which means in first place probably "to be discussed" how this can be done.

PR now approved on behalf of Release Management. Please review the last changes, approve, merge and create the release. Thanks!

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hdamker !

@AxelNennker
Copy link
Collaborator

/LGTM

@hdamker
Copy link
Contributor Author

hdamker commented Aug 16, 2024

Seems that merge and release creation left to me ...

@hdamker hdamker merged commit e451d8a into main Aug 16, 2024
1 check passed
@hdamker hdamker deleted the bigludo7-patch-2 branch August 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants