-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.1 with number-verification 1.0.0-rc.1 #126
Conversation
Co-authored-by: Herbert Damker <[email protected]>
…hecklist.md Co-authored-by: Herbert Damker <[email protected]>
…hecklist.md Co-authored-by: Herbert Damker <[email protected]>
…hecklist.md Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
…hecklist.md Co-authored-by: Herbert Damker <[email protected]>
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
NOTE: I had already previously reviewed in context of #121. Ready for final review by @camaraproject/release-management_maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentation/API_documentation/NumberVerification-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/NumberVerification-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/NumberVerification-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
@hdamker do we have anything pending in this PR? |
@fernandopradocabrillo The review from Release Management is missing ... as I created the PR I don't want to do it myself. @soadeyemo has assigned the review issue (camaraproject/ReleaseManagement#67) to himself. He is on vacation until Wednesday, so I expect he will pick it up afterwards. |
Rebase with main
Corrected raw content links
cd0b729
documentation/API_documentation/NumberVerification-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…hecklist.md set "Test result statement" from "N" to "tbd".
@AxelNennker @fernandopradocabrillo due to unavailability of other Release Management team members I have also done the final review on behalf of Release Management and have done also already the changes for the findings:
PR now approved on behalf of Release Management. Please review the last changes, approve, merge and create the release. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @hdamker !
/LGTM |
Seems that merge and release creation left to me ... |
What type of PR is this?
Add one of the following kinds:
Note: this PR from the branch used for #121 that was closed because of wrong target branch.
What this PR does / why we need it:
Generation of first release-candidate for NumberVerification API
This first release candidate r1.1 contains the definition and documentation of the release-candidate of the NumberVerification API v1.0.0-rc.1.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.